refactor: move hasPermission to async #28513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
refactor/hasPermission
branch
from
7898889
to
bc6901a
Compare
ggazzo
force-pushed
the
refactor/hasPermission
branch
from
9a0b21f
to
f5a6b30
Compare
ggazzo
added a commit
that referenced
this pull request
Mar 22, 2023
* notifyAdmins * Promise.await * refactor: move hasPermission to async (#28513) * .. * fix removeInvite * fix assets * .. * fix helperMethods * fix save user * first part * Fix lint * fix helpers * fix wrong imports * RoomCoordinator * hooks/login.ts * [ARCH-543] * [ARCH-539] * [ARCH-536] * seatsCap * [ARCH-514] * [ARCH-476] * [ARCH-443] * [ARCH-442] * ?? * [ARCH-452] * fix wrong imports * refactor: move canAccessRoomId to async * await updateMessage * fix * move addUserRoles to addUserRolesAsync * [ARCH-540] * [ARCH-484] * useInviteToken * [ARCH-430]] * [ARCH-391] * [ARCH-440] * setUserActiveStatus * jumptomessage * [ARCH-523] * [ARCH-528] * [ARCH-416] * fix imports checkUsernameAvailability * move addUserRoles to async * checkUsernameAvailability * lint --------- Co-authored-by: Rodrigo Nascimento <rodrigoknascimento@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments