refactor: Rooms Model 5/N #28619
Merged
refactor: Rooms Model 5/N #28619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
force-pushed
the
rooms-to-async-5
branch
from
d9650e2
to
862bbeb
Compare
rodrigok
requested changes
Mar 25, 2023
…into rooms-to-async-3
rodrigok
previously approved these changes
Mar 26, 2023
Codecov Report
@@ Coverage Diff @@
## develop #28619 +/- ##
===========================================
+ Coverage 44.91% 44.99% +0.08%
===========================================
Files 753 753
Lines 14665 14665
Branches 2130 2130
===========================================
+ Hits 6587 6599 +12
+ Misses 7776 7764 -12
Partials 302 302
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
force-pushed
the
rooms-to-async-5
branch
from
2a86309
to
8986afb
Compare
rodrigok
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments