-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Incomplete emails are being accepted at user registration #29115
fix: Incomplete emails are being accepted at user registration #29115
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #29115 +/- ##
===========================================
+ Coverage 46.44% 46.45% +0.01%
===========================================
Files 700 700
Lines 13051 13051
Branches 2237 2237
===========================================
+ Hits 6061 6063 +2
+ Misses 6661 6658 -3
- Partials 329 330 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forms make use of useForm hook from react-hook-form
Use the hook features like rule
instead of creating your own validation.
BTW, check other forms that are validating the email field, maybe there is a util function or an easier way to check this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use useForm from react-hook-form ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use useForm from react-hook-form ?
🦋 Changeset detectedLatest commit: 22c132b The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Proposed changes (including videos or screenshots)
Created a RegExp validator to check the emails in
packages/web-ui-registration/src/RegisterForm.tsx
and display an error.Issue(s)
Steps to test or reproduce
Further comments
WM-30