Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger url evaluation requiring CORS access #29304

Merged
merged 13 commits into from
Jun 13, 2023
Merged

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented May 19, 2023

Proposed changes (including videos or screenshots)

Issue(s)

SUP-61

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 7c5d683

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/livechat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: Trigger url evaluation requiring CORS access fix: Trigger url evaluation requiring CORS access May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #29304 (7c5d683) into develop (40d7f79) will decrease coverage by 1.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29304      +/-   ##
===========================================
- Coverage    46.53%   44.78%   -1.75%     
===========================================
  Files          700      665      -35     
  Lines        13044    12531     -513     
  Branches      2235     2214      -21     
===========================================
- Hits          6070     5612     -458     
+ Misses        6648     6593      -55     
  Partials       326      326              
Flag Coverage Δ
e2e 44.78% <ø> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review May 22, 2023 12:34
@aleksandernsilva aleksandernsilva requested review from a team as code owners May 22, 2023 12:34
MartinSchoeler
MartinSchoeler previously approved these changes May 22, 2023
@KevLehman KevLehman added this to the 6.3.0 milestone May 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels May 26, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 6, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 6, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 7, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2023
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Jun 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 12, 2023
@aleksandernsilva aleksandernsilva removed the stat: ready to merge PR tested and approved waiting for merge label Jun 13, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 13, 2023
@kodiakhq kodiakhq bot merged commit c0cb917 into develop Jun 13, 2023
@kodiakhq kodiakhq bot deleted the fix/trigger-page-url branch June 13, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants