Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Custom Translation setting does not wrap text correctly #29459

Merged
merged 10 commits into from
Jun 16, 2023

Conversation

felipe-rod123
Copy link
Contributor

Proposed changes (including videos or screenshots)

The JSON field does not deal with line break correctly. The whole UI on that section breaks when simply typing a big sequence of characters.
The text should be wrapped to avoid this type of behaviors.

After fixing the bug:

Full screen:

Issue(s)

WM-40

Steps to test or reproduce

On the JSON field, simply type a big sequence of characters.

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 5, 2023

🦋 Changeset detected

Latest commit: 8fd7d58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@felipe-rod123 felipe-rod123 marked this pull request as ready for review June 5, 2023 20:30
@felipe-rod123 felipe-rod123 requested a review from a team as a code owner June 5, 2023 20:30
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #29459 (8fd7d58) into develop (ae39f91) will increase coverage by 6.11%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29459      +/-   ##
===========================================
+ Coverage    39.44%   45.56%   +6.11%     
===========================================
  Files          671      694      +23     
  Lines        12711    12990     +279     
  Branches      2176     2224      +48     
===========================================
+ Hits          5014     5919     +905     
+ Misses        7401     6746     -655     
- Partials       296      325      +29     
Flag Coverage Δ
e2e 45.55% <ø> (+6.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 14, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 14, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@casalsgh casalsgh added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@casalsgh casalsgh added this to the 6.3.0 milestone Jun 16, 2023
@kodiakhq kodiakhq bot merged commit fa015f5 into develop Jun 16, 2023
@kodiakhq kodiakhq bot deleted the fix/custom-translations-text-wrap branch June 16, 2023 13:42
@hugocostadev hugocostadev added the squad: Workspace Management squad: Workspace Management label Jul 12, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants