Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Emoji being rendered as big #29493

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: Emoji being rendered as big #29493

merged 2 commits into from
Jun 15, 2023

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jun 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 7, 2023

🦋 Changeset detected

Latest commit: 7755748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo marked this pull request as ready for review June 7, 2023 14:54
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Merging #29493 (7755748) into develop (9da856c) will decrease coverage by 14.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #29493       +/-   ##
============================================
- Coverage    45.39%   30.79%   -14.60%     
============================================
  Files          688      578      -110     
  Lines        12900    10880     -2020     
  Branches      2224     1990      -234     
============================================
- Hits          5856     3351     -2505     
- Misses        6717     7317      +600     
+ Partials       327      212      -115     
Flag Coverage Δ
e2e 30.79% <ø> (-14.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title fix: Emoji being renderer as big fix: Emoji being renderered as big Jun 15, 2023
@ggazzo ggazzo changed the title fix: Emoji being renderered as big fix: Emoji being rendered as big Jun 15, 2023
@ggazzo ggazzo added this to the 6.3.0 milestone Jun 15, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 15, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 15, 2023
@ggazzo ggazzo merged commit 734db1d into develop Jun 15, 2023
@ggazzo ggazzo deleted the fix/emoji-big branch June 15, 2023 13:44
gabriellsh added a commit that referenced this pull request Jun 15, 2023
…to fix/slash-stub

* 'fix/slash-stub' of github.com:RocketChat/Rocket.Chat:
  fix: Unable to open Releases inside App info (#29418)
  ci: improve engagement dashboard selectors (#29541)
  fix: re-added pagination to department's agents table (#29523)
  chore: add message body fallback while markup is loading (#29550)
  fix: spotlight reacts to new rooms (#29547)
  fix: Emoji being rendered as big (#29493)
  refactor: omnichannel on-hold feature (#28252)
  refactor: Livechat Button to TS (#29535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants