Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meteor): Room history is lost when jumping to an older message #29528

Merged
merged 6 commits into from
Jun 16, 2023

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 13, 2023

Proposed changes (including videos or screenshots)

Clear loaded messages when jumping to older message that is not loaded.

Issue(s)

Steps to test or reproduce

  • Go to a room that has a lot of messages
  • Scroll up untill it loads more messages about 4 times (the more you go up, more noticeable it gets)
  • Quote a very old message
  • Go to the bottom of the page
  • Reload the page
  • Click the quote date (jump to quoted message)

The page should have loaded the older message and some surrounding messages, but the rest of the messages between those and the newest ones that were already loaded are gone.

Further comments

TC-729

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

🦋 Changeset detected

Latest commit: 7006972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gabriellsh gabriellsh changed the title fix(meteor): Room history is lost when jumping to a different message fix(meteor): Room history is lost when jumping to an older message Jun 13, 2023
@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #29528 (7006972) into develop (ae39f91) will decrease coverage by 14.56%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #29528       +/-   ##
============================================
- Coverage    45.67%   31.11%   -14.56%     
============================================
  Files          694      578      -116     
  Lines        12990    10881     -2109     
  Branches      2224     1990      -234     
============================================
- Hits          5933     3386     -2547     
- Misses        6728     7279      +551     
+ Partials       329      216      -113     
Flag Coverage Δ
e2e 31.11% <0.00%> (-14.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@scuciatto scuciatto added this to the 6.3.0 milestone Jun 15, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@gabriellsh gabriellsh added the stat: ready to merge PR tested and approved waiting for merge label Jun 16, 2023
@kodiakhq kodiakhq bot merged commit 0f22271 into develop Jun 16, 2023
@kodiakhq kodiakhq bot deleted the fix/messageHistory branch June 16, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants