Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve performance of getActiveLocalUserCount #29681

Merged
merged 3 commits into from
Jul 3, 2023

Conversation

rodrigok
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2023

⚠️ No Changeset found

Latest commit: 8a56b18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok marked this pull request as ready for review July 3, 2023 14:41
@rodrigok rodrigok requested a review from a team as a code owner July 3, 2023 14:41
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #29681 (8a56b18) into develop (0856e85) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29681      +/-   ##
===========================================
- Coverage    46.59%   46.56%   -0.03%     
===========================================
  Files          693      693              
  Lines        12934    12934              
  Branches      2241     2241              
===========================================
- Hits          6026     6023       -3     
  Misses        6583     6583              
- Partials       325      328       +3     
Flag Coverage Δ
e2e 46.53% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 3, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 3, 2023
@ggazzo ggazzo merged commit e05e581 into develop Jul 3, 2023
@ggazzo ggazzo deleted the chore/improve-getActiveLocalUserCount branch July 3, 2023 21:21
@sampaiodiego sampaiodiego added this to the 6.2.10 milestone Jul 4, 2023
sampaiodiego added a commit that referenced this pull request Jul 5, 2023
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@sampaiodiego sampaiodiego modified the milestones: 6.2.10, 6.2.9 Jul 5, 2023
gabriellsh added a commit that referenced this pull request Jul 12, 2023
…/reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (28 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  Release 6.2.9
  Revert "Release 6.2.9"
  fix(meteor): `room-opened` event not dispatching when navigating cached rooms (#29718)
  chore:  device management improve readability and performance (#29712)
  chore: throttle exceptions counter increment (#29719)
  chore: Improve performance of getActiveLocalUserCount (#29681)
  Release 6.2.9
  ci: update EE license (#29684)
  ci: Add missing `context` property on compose file (#29676)
  chore: add change stream option to get full doc (#29627)
  fix(meteor): Message composer keeps recording even though permission was denied (#29526)
  fix(meteor): Video Record button disabled on iOS browsers (#29649)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants