-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Current Chats tags filter not showing department tags #29758
Conversation
|
Codecov Report
@@ Coverage Diff @@
## develop #29758 +/- ##
===========================================
- Coverage 46.63% 43.95% -2.68%
===========================================
Files 694 642 -52
Lines 13004 11818 -1186
Branches 2250 2115 -135
===========================================
- Hits 6064 5195 -869
+ Misses 6616 6325 -291
+ Partials 324 298 -26
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This correctly updates the UI to query tags from BE however we will further need changes on BE to only return tags which the user has access to. We'd take this up on a separate PR
…reportUser * 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits) feat: Add missing variants to UIKit button (#29654) refactor: Remove Accountbox usage (#29786) chore: stop importing action manager as global (#29766) chore: create FeaturePreview Component (#29759) regression: add missing translations on MenuV2 replace (#29777) test: create mock package (#29765) fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756) regression: option to start video conferences disappearing for regular users (#29763) chore: bump fuselage packages docs: Updated README file (#29770) regression: Current Chats tags filter not showing department tags (#29758) chore: `CloudRoute` to typescript (#29762) refactor: Lazy initialization on client-side (#29764) fix: Canned Response custom tags break the GUI on enterprise (#29694) regression: fix condition to `GenericMenu` gap (#29761) test: add unit tests for feature preview hooks (#29755) chore: bump fuselage deps (#29739) refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744) fix: mentions and emojis inside bold, italic and strikethrough (#29391) chore: `GenericMenu` logic to add gap (#29751) ...
Proposed changes (including videos or screenshots)
Issue(s)
OC-1132
OC-1138
Steps to test or reproduce
Further comments