Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Current Chats tags filter not showing department tags #29758

Merged
merged 3 commits into from
Jul 8, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jul 7, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1132
OC-1138

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

⚠️ No Changeset found

Latest commit: bdda2f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva marked this pull request as ready for review July 7, 2023 12:58
@aleksandernsilva aleksandernsilva requested review from a team as code owners July 7, 2023 12:58
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #29758 (bdda2f6) into develop (0f2f37d) will decrease coverage by 2.68%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29758      +/-   ##
===========================================
- Coverage    46.63%   43.95%   -2.68%     
===========================================
  Files          694      642      -52     
  Lines        13004    11818    -1186     
  Branches      2250     2115     -135     
===========================================
- Hits          6064     5195     -869     
+ Misses        6616     6325     -291     
+ Partials       324      298      -26     
Flag Coverage Δ
e2e 43.94% <83.33%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

murtaza98
murtaza98 previously approved these changes Jul 7, 2023
Copy link
Contributor

@murtaza98 murtaza98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This correctly updates the UI to query tags from BE however we will further need changes on BE to only return tags which the user has access to. We'd take this up on a separate PR

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 7, 2023
@dionisio-bot dionisio-bot bot added stat: needs QA and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 7, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 7, 2023
@ggazzo ggazzo merged commit 5ff71b3 into develop Jul 8, 2023
@ggazzo ggazzo deleted the fix/current-chats-tags-filter branch July 8, 2023 03:06
gabriellsh added a commit that referenced this pull request Jul 13, 2023
…reportUser

* 'develop' of github.com:RocketChat/Rocket.Chat: (51 commits)
  feat: Add missing variants to UIKit button (#29654)
  refactor: Remove Accountbox usage (#29786)
  chore: stop importing action manager as global (#29766)
  chore: create FeaturePreview Component (#29759)
  regression: add missing translations on MenuV2 replace (#29777)
  test: create mock package (#29765)
  fix: Prevent app's bridges from overriding lastMsg prop on rooms col (#29756)
  regression: option to start video conferences disappearing for regular users (#29763)
  chore: bump fuselage packages
  docs: Updated README file (#29770)
  regression: Current Chats tags filter not showing department tags (#29758)
  chore: `CloudRoute` to typescript (#29762)
  refactor: Lazy initialization on client-side (#29764)
  fix: Canned Response custom tags break the GUI on enterprise (#29694)
  regression: fix condition to `GenericMenu` gap (#29761)
  test: add unit tests for feature preview hooks (#29755)
  chore: bump fuselage deps (#29739)
  refactor: Changed `getUserPreference` to `useUserPreference` on `useVoipSounds` (#29744)
  fix: mentions and emojis inside bold, italic and strikethrough (#29391)
  chore: `GenericMenu` logic to add gap (#29751)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: omnichannel stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants