-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: custom emoji file upload with FileSystem method #29795
Conversation
🦋 Changeset detectedLatest commit: 1c2686f The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29795 +/- ##
===========================================
- Coverage 46.63% 45.99% -0.64%
===========================================
Files 669 663 -6
Lines 12910 12849 -61
Branches 2253 2240 -13
===========================================
- Hits 6020 5910 -110
- Misses 6561 6614 +53
+ Partials 329 325 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
The issue was happening due to a lack of await the attempt of delete to finishes
Issue(s)
fix #29738
Steps to test or reproduce
Further comments