Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom emoji file upload with FileSystem method #29795

Merged
merged 10 commits into from
Jul 26, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Jul 12, 2023

Proposed changes (including videos or screenshots)

The issue was happening due to a lack of await the attempt of delete to finishes

Issue(s)

fix #29738

Steps to test or reproduce

  1. Go to rocket.chat client
  2. Go to Workspace > Settings > Custom Emoji FileSystem
  3. Change to something like:
    image
  4. Restart your server
  5. Try to add a new custom emoji In Workspace > Custom Emoji
  6. Notice that no error popups and in the terminal the contributor error appears

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jul 12, 2023

🦋 Changeset detected

Latest commit: 1c2686f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #29795 (1c2686f) into develop (8be25af) will decrease coverage by 0.64%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29795      +/-   ##
===========================================
- Coverage    46.63%   45.99%   -0.64%     
===========================================
  Files          669      663       -6     
  Lines        12910    12849      -61     
  Branches      2253     2240      -13     
===========================================
- Hits          6020     5910     -110     
- Misses        6561     6614      +53     
+ Partials       329      325       -4     
Flag Coverage Δ
e2e 45.98% <ø> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev added the squad: Workspace Management squad: Workspace Management label Jul 12, 2023
@casalsgh casalsgh added this to the 6.4.0 milestone Jul 12, 2023
.changeset/custom-emoji-fs.md Show resolved Hide resolved
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jul 26, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 26, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 26, 2023
@kodiakhq kodiakhq bot merged commit 4ce8ea8 into develop Jul 26, 2023
@kodiakhq kodiakhq bot deleted the fix/custom-emoji-fs branch July 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: Workspace Management squad: Workspace Management stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom emoji failed in FileSystem storage
4 participants