fix: engagement dashboard not working #30277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 33e5f64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #30277 +/- ##
========================================
Coverage 48.39% 48.40%
========================================
Files 700 700
Lines 13039 13039
Branches 2318 2318
========================================
+ Hits 6310 6311 +1
- Misses 6369 6372 +3
+ Partials 360 356 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
requested changes
Sep 4, 2023
pierre-lehnen-rc
previously approved these changes
Sep 5, 2023
matheusbsilva137
previously approved these changes
Sep 6, 2023
tapiarafael
dismissed stale reviews from matheusbsilva137 and pierre-lehnen-rc
The base branch was changed.
MarcosSpessatto
approved these changes
Sep 7, 2023
sampaiodiego
pushed a commit
that referenced
this pull request
Sep 14, 2023
gabriellsh
added a commit
that referenced
this pull request
Sep 19, 2023
…ove/iframeLogin * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) fix: Disables `GenericMenu` without any sections or items (#30319) i18n: Language update from LingoHub 🤖 on 2023-09-18Z (#30426) chore: remove connectToCloud option (#30430) chore: remove Troubleshoot options (#30429) chore: bump fuselage packages (#30424) chore: Webhooks page refactor (#30274) chore: color palette changes (#30385) fix: increase cron job check delay to 1 min (#30402) fix: Presence broadcast isn't enabled after license validation (#30282) test: create non private team and readonly team (#30371) Bump version to 6.5.0-develop refactor: Implement functional code for the 'useFilteredApps' hook (#30279) Release 6.4.0-rc.1 Release 6.3.6 regression: Login page callout messages (#30399) test: tests for muting and unmuting (#30286) regression: Fix rooms table not showing teams (#30361) regression: Move queue-timeout setting to CE and remove dependency on waiting queue (#30386) fix: engagement dashboard not working (#30277) Bump 6.3.6 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The aggregate function was not being call because of the name in the cron job is being the same of the finish sessions function, resulting in not having information to display on the Engagement Dashboard.
Issue(s)
Steps to test or reproduce
admin > engagement;Further comments
WM-158