Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Sticky Date for Improved Message Date Visibility #31310

Closed
wants to merge 3 commits into from
Closed

feat: Add Sticky Date for Improved Message Date Visibility #31310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a53406
Added sticky top for the message dates
abhipatel0211 Dec 23, 2023
f489a36
done with zindex
abhipatel0211 Jan 10, 2024
75ad089
Merge branch 'RocketChat:develop' into develop
abhipatel0211 Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions apps/meteor/client/views/room/MessageList/MessageList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { IRoom } from '@rocket.chat/core-typings';
import { isThreadMessage } from '@rocket.chat/core-typings';
import { MessageDivider } from '@rocket.chat/fuselage';
import { MessageDivider, Box } from '@rocket.chat/fuselage';
import { useSetting, useTranslation, useUserPreference } from '@rocket.chat/ui-contexts';
import type { ReactElement, ComponentProps } from 'react';
import React, { Fragment, memo } from 'react';
Expand Down Expand Up @@ -58,9 +58,13 @@ export const MessageList = ({ rid, scrollMessageList }: MessageListProps): React
return (
<Fragment key={message._id}>
{showDivider && (
<MessageDivider unreadLabel={showUnreadDivider ? t('Unread_Messages').toLowerCase() : undefined}>
{newDay && formatDate(message.ts)}
</MessageDivider>
<Box style={{ position: 'sticky', top: '0' , zIndex: '999' }}>
<MessageDivider unreadLabel={showUnreadDivider ? t('Unread_Messages').toLowerCase() : undefined}>
{newDay && formatDate(message.ts)}
</MessageDivider>

</Box>

)}

{visible && (
Expand Down
Loading