Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apps-Engine Deno Runtime update #31821

Merged
merged 110 commits into from
Jun 17, 2024
Merged

feat: Apps-Engine Deno Runtime update #31821

merged 110 commits into from
Jun 17, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Feb 23, 2024

Proposed changes (including videos or screenshots)

This PR refactors the usage of the Apps-Engine so that it is compatible with the new Deno Runtime, as implemented in RocketChat/Rocket.Chat.Apps-engine#665

Issue(s)

PROJ-5

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: a01c3c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/omnichannel-services Minor
rocketchat-services Minor
@rocket.chat/omnichannel-transcript Minor
@rocket.chat/authorization-service Minor
@rocket.chat/web-ui-registration Major
@rocket.chat/stream-hub-service Minor
@rocket.chat/uikit-playground Minor
@rocket.chat/presence-service Minor
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/instance-status Minor
@rocket.chat/account-service Minor
@rocket.chat/mock-providers Minor
@rocket.chat/api-client Minor
@rocket.chat/ddp-client Minor
@rocket.chat/pdf-worker Minor
@rocket.chat/ui-theming Minor
@rocket.chat/core-services Minor
@rocket.chat/model-typings Minor
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/ddp-streamer Minor
@rocket.chat/queue-worker Minor
@rocket.chat/presence Minor
@rocket.chat/ui-composer Minor
@rocket.chat/ui-contexts Major
@rocket.chat/license Minor
@rocket.chat/gazzodown Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/livechat Minor
@rocket.chat/models Minor
@rocket.chat/ui-kit Minor
@rocket.chat/apps Minor
@rocket.chat/cron Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.70%. Comparing base (2ef71e8) to head (a01c3c8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31821      +/-   ##
===========================================
- Coverage    56.42%   55.70%   -0.72%     
===========================================
  Files         2479     2416      -63     
  Lines        54581    53470    -1111     
  Branches     11269    11002     -267     
===========================================
- Hits         30795    29785    -1010     
+ Misses       21111    21058      -53     
+ Partials      2675     2627      -48     
Flag Coverage Δ
e2e 54.78% <ø> (-1.34%) ⬇️
unit 71.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert force-pushed the feat/apps-deno-runtime branch from d9accc0 to f5656bb Compare March 14, 2024 19:47
d-gubert and others added 6 commits March 16, 2024 15:17
* chore: use apps-engine with deno

* fix: async operations

* fix: async
* refactor: convert to typescript

* feat: change storeEntries to receive logEntries instead appconsole instance

* refactor: remove `logs-storage.js`

* refactor: remove type `any`

* fix: type errors

* fix: implement correct method

* chore: use apps engine with deno vm

* Fix import

---------

Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
* Improve readability for loading apps on startup

* Fix slash command registration validation

* Fix '/api/apps/installed' endpoint

* fix: return correct logs information

* Remove trycatch in http bridge as it was causing invalid responses

* fix: return installed apps

* Remove hardcoded url in http bridge

* fix: use url with params

* fix: slashcommand preview (#31814)

---------

Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
@d-gubert d-gubert force-pushed the feat/apps-deno-runtime branch from f5656bb to e7a23ca Compare March 16, 2024 18:18
@d-gubert d-gubert changed the base branch from develop to release-7.0.0 May 21, 2024 16:19
@d-gubert d-gubert changed the base branch from release-7.0.0 to develop May 21, 2024 16:19
@d-gubert d-gubert modified the milestones: 7.0, 6.10 Jun 10, 2024
@d-gubert d-gubert marked this pull request as ready for review June 14, 2024 13:14
@d-gubert d-gubert requested review from a team as code owners June 14, 2024 13:14
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jun 14, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 14, 2024
.github/workflows/ci-test-e2e.yml Outdated Show resolved Hide resolved
apps/meteor/package.json Outdated Show resolved Hide resolved
@kodiakhq kodiakhq bot merged commit 4f72d62 into develop Jun 17, 2024
43 of 46 checks passed
@kodiakhq kodiakhq bot deleted the feat/apps-deno-runtime branch June 17, 2024 22:17
gabriellsh added a commit that referenced this pull request Jun 18, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Not possible to edit room without proper permission with retention policy enabled (#32547)
  feat: Apps-Engine Deno Runtime update (#31821)
  feat: E2EE room setup header (#32446)
  fix: E2EE thread main message reactivity (#32381)
  chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113)
  fix: Long katex strings breaking overflow in x axis (#32609)
  fix: Force highlighted code language registration (#32507)
  fix: sidebar last message E2EE (#32431)
  chore: remove message column on moderation console (#32432)
  fix: Accepted Media Types settings validation (#32478)
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants