Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Livechat): registerguest() with different guests #32072

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Mar 26, 2024

CORE-220

Adds tests to test the registerguest livechat api function with different guests

Copy link

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: bcdb1d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.79%. Comparing base (545a316) to head (bcdb1d5).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32072      +/-   ##
===========================================
+ Coverage    54.70%   54.79%   +0.08%     
===========================================
  Files         2299     2299              
  Lines        50739    50739              
  Branches     10384    10380       -4     
===========================================
+ Hits         27756    27800      +44     
+ Misses       20490    20446      -44     
  Partials      2493     2493              
Flag Coverage Δ
e2e 53.79% <ø> (+0.08%) ⬆️
e2e-api 40.16% <ø> (+0.13%) ⬆️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 27, 2024 11:56
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner March 27, 2024 11:56
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 27, 2024
@ggazzo ggazzo added this to the 7.0 milestone Mar 27, 2024
@ggazzo ggazzo merged commit 5b7623d into develop Mar 27, 2024
49 checks passed
@ggazzo ggazzo deleted the registerguest-test branch March 27, 2024 14:24
@ggazzo ggazzo modified the milestones: 7.0, 6.8 Apr 9, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is not mergeable
    Please fix the issues and try again
    If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Apr 9, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is not mergeable
    Please fix the issues and try again
    If you have any trouble, please check the PR guidelines

@ggazzo
Copy link
Member

ggazzo commented Apr 23, 2024

/backport 6.6.7

Copy link
Contributor

dionisio-bot bot commented Apr 23, 2024

Sorry, I couldn't do that backport because of conflicts. Could you please solve them?

you can do so by running the following commands:

git fetch
git checkout backport-6.6.7-32072
git cherry-pick 5b7623dfe45a450c7d18094617d176117ccc1e39
// solve the conflict
git push

after that just run /backport 6.6.7 again

@ggazzo
Copy link
Member

ggazzo commented Apr 23, 2024

/backport 6.6.7

Copy link
Contributor

dionisio-bot bot commented Apr 23, 2024

Pull request #32299 added to Project: "Patch 6.6.7"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants