Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: api login should not suggest which credential is wrong #32159

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix!: api login should not suggest which credential is wrong #32159

merged 3 commits into from
Apr 9, 2024
+33 −26

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 9, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2024

🦋 Changeset detected

Latest commit: a236e2a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 9, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@ggazzo ggazzo marked this pull request as ready for review April 9, 2024 16:46
@ggazzo ggazzo requested review from a team as code owners April 9, 2024 16:46
@ggazzo ggazzo added this to the 7.0 milestone Apr 9, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 9, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 9, 2024
@ggazzo ggazzo merged commit 3dd2183 into release-7.0.0 Apr 9, 2024
56 of 57 checks passed
@ggazzo ggazzo deleted the fix/api-login branch April 9, 2024 16:47
ggazzo added a commit that referenced this pull request Apr 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
ad44d9e
ggazzo added a commit that referenced this pull request Apr 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
a209cb7
ggazzo added a commit that referenced this pull request Apr 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
7ce9ee2
ggazzo added a commit that referenced this pull request Apr 12, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
3381ff3
ggazzo added a commit that referenced this pull request Apr 12, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
4d5a13c
ggazzo added a commit that referenced this pull request Apr 20, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
79baee8
ggazzo added a commit that referenced this pull request Apr 24, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
0cf25be
ggazzo added a commit that referenced this pull request Apr 24, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
9b3d017
matheusbsilva137 pushed a commit that referenced this pull request May 2, 2024
@ggazzo @matheusbsilva137
fix!: api login should not suggest which credential is wrong (#32159)
3557dc6
ggazzo added a commit that referenced this pull request May 7, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
fcc9265
ggazzo added a commit that referenced this pull request May 9, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
45c5a67
ggazzo added a commit that referenced this pull request May 15, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
f5584c6
ggazzo added a commit that referenced this pull request Jun 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
3866f97
ggazzo added a commit that referenced this pull request Jun 19, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
651ad3e
ggazzo added a commit that referenced this pull request Jun 19, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
9eb48b3
ggazzo added a commit that referenced this pull request Jun 24, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
29b15ed
ggazzo added a commit that referenced this pull request Aug 15, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
00c7c2b
ggazzo added a commit that referenced this pull request Sep 5, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
0e06306
ggazzo added a commit that referenced this pull request Sep 5, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
4097b61
ggazzo added a commit that referenced this pull request Sep 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
4b841b9
ggazzo added a commit that referenced this pull request Sep 13, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
0d8c60d
ggazzo added a commit that referenced this pull request Sep 14, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
505cba9
ggazzo added a commit that referenced this pull request Sep 16, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
79fc715
MartinSchoeler pushed a commit that referenced this pull request Sep 18, 2024
@ggazzo @MartinSchoeler
fix!: api login should not suggest which credential is wrong (#32159)
cc1235d
ggazzo added a commit that referenced this pull request Sep 25, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
dcc92d8
ggazzo added a commit that referenced this pull request Sep 25, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
089145f
ggazzo added a commit that referenced this pull request Sep 27, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
340491e
ggazzo added a commit that referenced this pull request Sep 27, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
b29bc61
ggazzo added a commit that referenced this pull request Oct 8, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
d57bff9
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@ggazzo @sampaiodiego
fix!: api login should not suggest which credential is wrong (#32159)
6f32b4e
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
@ggazzo @sampaiodiego
fix!: api login should not suggest which credential is wrong (#32159)
a3a0532
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
@ggazzo @abhinavkrin
fix!: api login should not suggest which credential is wrong (#32159)
ccdf4a0
ggazzo added a commit that referenced this pull request Oct 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
7ce9407
ggazzo added a commit that referenced this pull request Oct 11, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
b2faa6a
ggazzo added a commit that referenced this pull request Oct 14, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
42aa591
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
@ggazzo @MartinSchoeler
fix!: api login should not suggest which credential is wrong (#32159)
5bf8408
ggazzo added a commit that referenced this pull request Oct 15, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
f56f187
ggazzo added a commit that referenced this pull request Oct 17, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
8e15a00
ggazzo added a commit that referenced this pull request Oct 17, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
552b255
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@ggazzo @abhinavkrin
fix!: api login should not suggest which credential is wrong (#32159)
9572375
@ZhaoQi99
Copy link

ZhaoQi99 commented Nov 1, 2024

@ggazzo Can you optimize the frontend message? It may confuse users when an existing user enters the wrong password.

ggazzo added a commit that referenced this pull request Nov 6, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
50db9f8
ggazzo added a commit that referenced this pull request Nov 6, 2024
@ggazzo
fix!: api login should not suggest which credential is wrong (#32159)
e1edf9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ggazzo @ZhaoQi99