Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(livechat): Persistent after-guest-registration Trigger Messages (livechat client) #32233

Merged
merged 10 commits into from
May 10, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Apr 17, 2024

SUP-550

Makes the triggers fired by the condition after-guest-registration persist on the livechat client, it will persist through reloads and pagination, only resetting when a conversation is closed (no changes were done on the agent side of the conversation)

Copy link
Contributor

dionisio-bot bot commented Apr 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Apr 17, 2024

🦋 Changeset detected

Latest commit: 0277c98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/livechat Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.59%. Comparing base (bf4b4cc) to head (0277c98).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32233      +/-   ##
===========================================
+ Coverage    55.55%   55.59%   +0.04%     
===========================================
  Files         2405     2405              
  Lines        52929    52929              
  Branches     10872    10873       +1     
===========================================
+ Hits         29405    29427      +22     
+ Misses       20952    20906      -46     
- Partials      2572     2596      +24     
Flag Coverage Δ
e2e 54.92% <ø> (+0.03%) ⬆️
unit 73.41% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the title fix(livechat): After Registration Triggers should persist after reload feat(livechat): Persistent Trigger Messages (livechat client) Apr 29, 2024
@MartinSchoeler MartinSchoeler changed the title feat(livechat): Persistent Trigger Messages (livechat client) feat(livechat): Persistent after-guest-registration Trigger Messages (livechat client) Apr 30, 2024
@MartinSchoeler MartinSchoeler added this to the 6.9 milestone Apr 30, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review April 30, 2024 14:15
@MartinSchoeler MartinSchoeler requested review from a team as code owners April 30, 2024 14:15
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels May 6, 2024
@jessicaschelly jessicaschelly removed the stat: ready to merge PR tested and approved waiting for merge label May 6, 2024
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label May 10, 2024
@kodiakhq kodiakhq bot merged commit e26397a into develop May 10, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the trigger-msg-refresh branch May 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants