Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Omnichannel Tags E2E tests #32241

Merged
merged 14 commits into from
May 14, 2024
Merged

test: Add Omnichannel Tags E2E tests #32241

merged 14 commits into from
May 14, 2024

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented Apr 18, 2024

Add e2e tests to the Tags section on Omnichannel.

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-276

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: 649dcda

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (ff35376) to head (649dcda).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32241      +/-   ##
===========================================
- Coverage    55.56%   54.42%   -1.14%     
===========================================
  Files         2401     2330      -71     
  Lines        52847    51832    -1015     
  Branches     10861    10664     -197     
===========================================
- Hits         29365    28212    -1153     
- Misses       20881    21101     +220     
+ Partials      2601     2519      -82     
Flag Coverage Δ
e2e 52.74% <ø> (-2.19%) ⬇️
unit 73.26% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

dionisio-bot bot commented Apr 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@csuadev csuadev marked this pull request as ready for review April 23, 2024 17:34
@csuadev csuadev requested review from a team as code owners April 23, 2024 17:34
@csuadev csuadev added this to the Next-release-prep milestone Apr 23, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we try to avoid these additional props to get locators? Prefer using the element role

@csuadev csuadev requested a review from dougfabris April 25, 2024 16:21
@dougfabris dougfabris modified the milestones: Next-release-prep, 6.9 Apr 26, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix the indentation + EOF for all the test files.

apps/meteor/tests/e2e/omnichannel/omnichannel-tags.spec.ts Outdated Show resolved Hide resolved
MarcosSpessatto
MarcosSpessatto previously approved these changes May 8, 2024
KevLehman
KevLehman previously approved these changes May 9, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels May 9, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label May 9, 2024
@dougfabris dougfabris dismissed stale reviews from MarcosSpessatto and KevLehman via cf1a9af May 10, 2024 13:43
@dougfabris dougfabris added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA assured Means it has been tested and approved by a company insider labels May 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 10, 2024
@csuadev csuadev requested a review from KevLehman May 13, 2024 11:02
@kodiakhq kodiakhq bot merged commit 4b6951b into develop May 14, 2024
42 of 47 checks passed
@kodiakhq kodiakhq bot deleted the chore/oc-tags-e2e-tests branch May 14, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants