-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Omnichannel Tags E2E tests #32241
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32241 +/- ##
===========================================
- Coverage 55.56% 54.42% -1.14%
===========================================
Files 2401 2330 -71
Lines 52847 51832 -1015
Branches 10861 10664 -197
===========================================
- Hits 29365 28212 -1153
- Misses 20881 21101 +220
+ Partials 2601 2519 -82
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like this PR is ready to merge! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we try to avoid these additional props to get locators? Prefer using the element role
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix the indentation + EOF for all the test files.
cf1a9af
Add e2e tests to the Tags section on Omnichannel.
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-276
Steps to test or reproduce
Further comments