Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved ux for 360 width media #3229

Closed
wants to merge 6 commits into from

Conversation

ARivottiC
Copy link

@RocketChat/core

  • side-nav: hide footer
  • fixed-title:
    • room icon smaller and bolder
    • room-title smaller and bolder
    • room-topic in a different line, smaller and with italic
    • favorite moved to the far rigth and increased in size
    • burguer smaller and closer to the edge
  • flex-tab-bar now slides up and down
  • flex-tab-bar now horizontally after fixed-tile
  • message: reduce the space around the button
  • message-form:
    • removed the space around the message box
    • emoji icon move to the left side of the box
    • attach moved to the right side of the box
    • change the behaviour of the buttons based on the message box's text:
      • if empty, show attach and mic
      • if higher than 0, hide attach and mic and show send
    • hide tooltips
    • hide user typing
  • emoji-picker:
    • now appears bellow the message-form
    • search box removed

6
5
4
3
2
1
0

André Rivotti Casimiro and others added 3 commits May 13, 2016 04:05
* side-nav: hide footer
* fixed-title:
  * room icon smaller and bolder
  * room-title smaller and bolder
  * room-topic in a different line, smaller and with italic
  * favorite moved to the far rigth and increased in size
  * burguer smaller and closer to the edge
* flex-tab-bar now slides up and down
* flex-tab-bar now horizontally after fixed-tile
* message: reduce the space around the button
* message-form:
  * removed the space around the message box
  * emoji icon move to the left side of the box
  * attach moved to the right side of the box
  * change the behaviour of the buttons based on the message box's text:
    * if empty, show attach and mic
    * if higher than 0, hide attach and mic and show send
  * hide tooltips
  * hide user typing
* emoji-picker:
  * now appears bellow the message-form
  * search box removed
@geekgonecrazy
Copy link
Contributor

@ARivottiC wow!! Just amazing! Thanks a ton for contributing!

We'll take a look at this and see about getting it merged!

@RocketChat/core

@lucasvanhalst
Copy link
Contributor

Can you still see all of the flex tab buttons on smaller devices?

@ARivottiC
Copy link
Author

@lucasvanhalst like it is, probably not. What's the minimum target, 320px? This could be a slider. Other option I considered was adding a drop down it the top right corner.

@lucasvanhalst
Copy link
Contributor

A dropdown would probably be the best on mobile, to save some precious screen space :)

@engelgabriel
Copy link
Member

This looks awesome! I am looking forward to try this out!

@ARivottiC
Copy link
Author

@lucasvanhalst I'll try to add it today. I'm was really looking forward for suggestions and different approaches :). Thank you.

@engelgabriel
Copy link
Member

@ARivottiC have you seed the customisations at https://chat.creators.co/ ?

@ARivottiC
Copy link
Author

No @engelgabriel, omw, thanks.

André Rivotti Casimiro added 3 commits May 20, 2016 12:49
* side-nav: hide footer
* fixed-title:
  * room icon smaller and bolder
  * room-title smaller and bolder
  * room-topic in a different line, smaller and with italic
  * favorite moved to the far rigth and increased in size
  * burguer smaller and closer to the edge
* flex-tab-bar now slides up and down
* flex-tab-bar now horizontally after fixed-tile
* message: reduce the space around the button
* message-form:
  * removed the space around the message box
  * emoji icon move to the left side of the box
  * attach moved to the right side of the box
  * change the behaviour of the buttons based on the message box's text:
    * if empty, show attach and mic
    * if higher than 0, hide attach and mic and show send
  * hide tooltips
  * hide user typing
* emoji-picker:
  * now appears bellow the message-form
  * search box removed
@@ -15,7 +17,8 @@ Template.messageBox.events({

input.val(textAreaTxt.substring(0, caretPos) + emojiValue + textAreaTxt.substring(caretPos));

input.focus();
if ( !window.matchMedia('all and (min-width: 360px)').matches )
input.focus();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paradisetradingsolutions

Any updates on when this will be resolved and released? This would make the mobile app way more functional! Looks great :) I think a horizontal swipe to access sidebar would be great, it really gets in the way of the chat stream on the side, It would take up space sitting on top too

@paradisetradingsolutions

Would this development be added to the iOS app as well?

@engelgabriel engelgabriel added this to the 0.50.0 milestone Dec 21, 2016
@engelgabriel
Copy link
Member

@karlprieb I like the improvements here. Let's pull this into a new branch and try to create a new PR form this.

@istanleyyaw
Copy link

this would be great for mobile device,and one more limitation is image zoom,lack of zoom make it hard to use when contain a lot of text on img

@engelgabriel engelgabriel modified the milestones: 0.50.0, Short-term Jan 24, 2017
@RichardFoxworthy
Copy link

is this being deployed? current mobile UX is dire!

@geekgonecrazy geekgonecrazy removed this from the Short-term milestone Apr 18, 2018
@graywolf336
Copy link
Contributor

I am going to go ahead and close this one, as we recently did a complete overhaul of our website design and along with that came a change in the tab bar/contextual bar. Here is the pull request that changed the contextual bar: #9481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants