Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(livechat): Fix OC - Livechat New Chat Triggers - After Registration flaky test #32309

Merged
merged 9 commits into from
Jul 22, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Apr 24, 2024

CORE-310

Fixes issue with test not waiting for a 200 on a setting change

Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: fc5615e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (6599afe) to head (fc5615e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32309      +/-   ##
===========================================
+ Coverage    55.56%   55.57%   +0.01%     
===========================================
  Files         2636     2637       +1     
  Lines        57277    57338      +61     
  Branches     11862    11871       +9     
===========================================
+ Hits         31827    31868      +41     
- Misses       22760    22770      +10     
- Partials      2690     2700      +10     
Flag Coverage Δ
e2e 54.22% <ø> (-0.04%) ⬇️
unit 72.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

dionisio-bot bot commented Apr 24, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 11, 2024 19:18
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 11, 2024 19:18
@MartinSchoeler MartinSchoeler added this to the 6.11 milestone Jul 11, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2024
@kodiakhq kodiakhq bot merged commit d9fdf02 into develop Jul 22, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the after-reg-trigger-flaky branch July 22, 2024 21:09
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants