-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pdf-transcript): Don't error out when trying to process an image bigger than NATS max payload #32318
Conversation
…ttempted to be fetched
🦋 Changeset detectedLatest commit: effb315 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32318 +/- ##
========================================
Coverage 55.59% 55.59%
========================================
Files 2404 2403 -1
Lines 52896 52865 -31
Branches 10862 10857 -5
========================================
- Hits 29409 29392 -17
+ Misses 20889 20872 -17
- Partials 2598 2601 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
I mean why not Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit tests will be added in a subsequent PR.
https://rocketchat.atlassian.net/browse/CORE-398
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Fixed error handling for files bigger than NATS max allowed payload. This should prevent PDFs from erroring out when generating from rooms that contain heavy images. Also added projections to user/rooms db calls