Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Video Conf call joined translation param #32327

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Apr 29, 2024

Proposed changes (including videos or screenshots)

The translation param being passed was wrong due to which the translation wasn't working as expected.

Issue(s)

image

Steps to test or reproduce

Further comments

SUP-511

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 1265cd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/meteor Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Apr 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.56%. Comparing base (bc50dd5) to head (1265cd6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32327      +/-   ##
===========================================
+ Coverage    51.30%   55.56%   +4.26%     
===========================================
  Files         2028     2378     +350     
  Lines        46811    52144    +5333     
  Branches      9491    10664    +1173     
===========================================
+ Hits         24015    28975    +4960     
- Misses       20581    20628      +47     
- Partials      2215     2541     +326     
Flag Coverage Δ
e2e 54.85% <ø> (+8.77%) ⬆️
unit 75.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review April 29, 2024 16:17
@yash-rajpal yash-rajpal added this to the 6.9 milestone Apr 29, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2024
@kodiakhq kodiakhq bot merged commit 6205ef1 into develop Apr 29, 2024
42 of 43 checks passed
@kodiakhq kodiakhq bot deleted the fix-translation-param branch April 29, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants