Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(omnichannel): afterTakeInquiry room as required param #32389

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 8, 2024

OPI-14

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-440

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 0310945

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (1566412) to head (0310945).
Report is 40 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32389      +/-   ##
===========================================
- Coverage    56.88%   56.81%   -0.08%     
===========================================
  Files         2497     2499       +2     
  Lines        55315    55470     +155     
  Branches     11410    11440      +30     
===========================================
+ Hits         31468    31516      +48     
- Misses       21146    21269     +123     
+ Partials      2701     2685      -16     
Flag Coverage Δ
unit 72.22% <100.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the refactor/afterTakeInquiry branch 2 times, most recently from 45132f0 to 691fa18 Compare May 8, 2024 22:51
@MartinSchoeler MartinSchoeler modified the milestone: 6.10 Jun 10, 2024
@ggazzo ggazzo force-pushed the refactor/afterTakeInquiry branch from 420167f to f13485a Compare July 10, 2024 02:13
@ggazzo ggazzo marked this pull request as ready for review July 10, 2024 13:27
@ggazzo ggazzo requested review from a team as code owners July 10, 2024 13:27
@ggazzo ggazzo changed the title refactor: afterTakeInquiry room as required param refacto(omnichannel)r: afterTakeInquiry room as required param Jul 10, 2024
@ggazzo ggazzo changed the title refacto(omnichannel)r: afterTakeInquiry room as required param refactor(omnichannel): afterTakeInquiry room as required param Jul 10, 2024
@ggazzo ggazzo added this to the 6.11 milestone Jul 10, 2024
@ggazzo ggazzo merged commit 0adc63d into develop Jul 10, 2024
41 of 42 checks passed
@ggazzo ggazzo deleted the refactor/afterTakeInquiry branch July 10, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants