Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: QueueInactivityMonitor not processing inquiries #32452

Merged
merged 7 commits into from
Jun 18, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented May 17, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-579

Steps to test or reproduce

Further comments

Apparently the callback that created the job to remove the items from the queue was checking a createdAt property that didn't even exists on types. Since the function was typed as any, this created the perfect place for this happen.

Types were updated, missing property check was removed (now we just check for _updatedAt) and changed the use of a global value since we have the value in scope from the watch call.

Copy link
Contributor

dionisio-bot bot commented May 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 17, 2024

🦋 Changeset detected

Latest commit: 80cb3dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KevLehman KevLehman added this to the 6.9 milestone May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.56%. Comparing base (b23f9ed) to head (80cb3dd).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32452      +/-   ##
===========================================
+ Coverage    56.47%   56.56%   +0.08%     
===========================================
  Files         2482     2483       +1     
  Lines        54620    54663      +43     
  Branches     11283    11280       -3     
===========================================
+ Hits         30849    30918      +69     
+ Misses       21101    21071      -30     
- Partials      2670     2674       +4     
Flag Coverage Δ
e2e 56.17% <ø> (-0.01%) ⬇️
unit 72.25% <98.41%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review May 17, 2024 18:33
@KevLehman KevLehman requested a review from a team as a code owner May 17, 2024 18:33
@KevLehman
Copy link
Contributor Author

Note: no tests for this as the minimum time for this job to run is one min and waiting for the CI to run after one min is no good

Will create a separate task to add unit tests

@scuciatto scuciatto modified the milestones: 6.9, 6.10 May 21, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Jun 5, 2024
@KevLehman KevLehman dismissed stale reviews from MartinSchoeler and MarcosSpessatto via 5c908a2 June 13, 2024 21:04
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 18, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 18, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Jun 18, 2024
@kodiakhq kodiakhq bot merged commit 1bdffcd into develop Jun 18, 2024
47 checks passed
@kodiakhq kodiakhq bot deleted the fix/queue-inactivity-mon branch June 18, 2024 16:58
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants