regression: Remove impossible sorting from users table "registration status" column #32506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.9.0 #32506 +/- ##
=================================================
- Coverage 56.00% 55.98% -0.02%
=================================================
Files 2431 2431
Lines 53556 53556
Branches 11029 11029
=================================================
- Hits 29992 29986 -6
+ Misses 20960 20935 -25
- Partials 2604 2635 +31
Flags with carried forward coverage won't be shown. Click here to find out more. |
rique223
force-pushed
the
regression/users-impossible-sort
branch
2 times, most recently
from
86b4ceb to
ba72f3b
Compare
rique223
force-pushed
the
regression/users-impossible-sort
branch
from
ba72f3b to
cdef7ab
Compare
…tatus" column Removed the sorting functionality of the users table "registration status" column. This info should be generated in the back-end but it is being infered in the front which makes the sorting of this column impractical.
rique223
force-pushed
the
regression/users-impossible-sort
branch
from
cdef7ab to
cc59e76
Compare
tassoevan
approved these changes
May 29, 2024
jessicaschelly
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jun 3, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: Release 6.9.0 Release 6.9.0-rc.2 fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) regression: Hide prune section based on permission (#32531) fix: Users in role table not rendering the empty state properly (#32412) refactor: EmailInbox out of DB Watcher (#32501) ci: increase issue allowed stale time (#32523) regression: Remove impossible sorting from users table "registration status" column (#32506) feat: Add contentDisposition option to file storages (#31974) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508) Release 6.9.0-rc.1 fix: Re-login same browser tab issues (#32479) regression: Replace read receipt single icon (#32486) regression: Incorrect retention policy banner's display rule for teams (#32483) chore: Publish npm packages again (#32463) ci: publish missing Omnichannel services to DockerHub (#32462) Release 6.9.0-rc.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Removed the sorting functionality from the users table "registration status" column. This info should be generated in the back-end but it is being infered in the front which makes the sorting of this column impractical. Another PR fixing this issue will be released in the close future.
Demo image:
Issue(s)
Steps to test or reproduce
Further comments
Jira task: CONN-217