-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use prettier
on UI tests files
#32526
Conversation
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32526 +/- ##
===========================================
- Coverage 56.41% 56.38% -0.04%
===========================================
Files 2436 2437 +1
Lines 53742 53773 +31
Branches 11076 11082 +6
===========================================
Hits 30319 30319
- Misses 20779 20804 +25
- Partials 2644 2650 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
3b05bcd
to
17988e2
Compare
eslint-config/standard
on UI tests filesprettier
on UI tests files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6dfdf42
to
c9d48a8
Compare
https://rocketchat.atlassian.net/browse/CORE-489
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This enables prettier rules to run on E2E UI tests files which will help us to with the style and foratting of our codebase