Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use prettier on UI tests files #32526

Merged
merged 2 commits into from
Jun 10, 2024
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented May 30, 2024

https://rocketchat.atlassian.net/browse/CORE-489

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

This enables prettier rules to run on E2E UI tests files which will help us to with the style and foratting of our codebase

Copy link
Contributor

dionisio-bot bot commented May 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: c9d48a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.38%. Comparing base (04b0a76) to head (c9d48a8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32526      +/-   ##
===========================================
- Coverage    56.41%   56.38%   -0.04%     
===========================================
  Files         2436     2437       +1     
  Lines        53742    53773      +31     
  Branches     11076    11082       +6     
===========================================
  Hits         30319    30319              
- Misses       20779    20804      +25     
- Partials      2644     2650       +6     
Flag Coverage Δ
e2e 56.08% <ø> (-0.07%) ⬇️
unit 72.15% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the chore/eslint-for-tests branch from 3b05bcd to 17988e2 Compare May 31, 2024 14:06
@KevLehman KevLehman changed the title chore: Use eslint-config/standard on UI tests files chore: Use prettier on UI tests files May 31, 2024
@KevLehman KevLehman marked this pull request as ready for review May 31, 2024 15:43
@KevLehman KevLehman requested review from a team as code owners May 31, 2024 15:43
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 31, 2024
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiagoevanp tiagoevanp requested a review from ggazzo May 31, 2024 16:56
MarcosSpessatto
MarcosSpessatto previously approved these changes Jun 7, 2024
@KevLehman KevLehman added this to the 6.10 milestone Jun 7, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 7, 2024
@kodiakhq kodiakhq bot merged commit 1e8d97f into develop Jun 10, 2024
48 of 49 checks passed
@kodiakhq kodiakhq bot deleted the chore/eslint-for-tests branch June 10, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants