fix: Installed apps not appearing in the list if they're not published in the Marketplace

[d-gubert]

Proposed changes (including videos or screenshots)

In the internal apps provider, add non-private apps that are installed in the instance to the installed app list.

Issue(s)

CONN-220

Steps to test or reproduce

NOTE: To test this, you will need access to the workspace's database

1. Install a private app in the workspace. Any app will suffice.
2. Access the database (any method will do) and update the record of the app that has just been installed, changing the installationSource to marketplace
   • Example query db.getCollection("rocketchat_apps").updateOne({ id: "YOUR APP ID" }, { $set: { installationSource: "marketplace" } })
3. Restart the server (otherwise the changes on the DB won't be picked up)
4. The private app will not be shown in either the "Installed" or "Private Apps" list

This simulates the situation of an app unpublished from the Marketplace, as the record of the app will be present in the instance but not in the return from the Marketplace API

Further comments

Seeing this in the real world is relatively complicated without database access. The real world scenario that would cause this bug is a workspace installing an app from the Marketplace and later on this app being de-listed/unpublished from the Marketplace.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: f592533

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.37%. Comparing base (2b14bf6) to head (f592533).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32534      +/-   ##
===========================================
- Coverage    56.37%   56.37%   -0.01%     
===========================================
  Files         2435     2437       +2     
  Lines        53728    53770      +42     
  Branches     11068    11082      +14     
===========================================
+ Hits         30289    30311      +22     
- Misses       20796    20812      +16     
- Partials      2643     2647       +4     

Flag	Coverage Δ
e2e	56.07% <ø> (-0.04%)	⬇️
unit	72.13% <88.09%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.