Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable some message menu items for encrypted messages. #32559

Merged
merged 13 commits into from
Jun 19, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jun 5, 2024

Proposed changes (including videos or screenshots)

Currently, it is not possible to properly share the content of encrypted messages outside the room.The forwarded message, message link, or quote appears in the destination room as a hash.
So, it is needed to make clear to users that it is not possible to share encrypted messages content.

image

Issue(s)

Steps to test or reproduce

Further comments

E2EE2-25

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 165e52c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.52%. Comparing base (cd97aac) to head (165e52c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32559      +/-   ##
===========================================
- Coverage    56.55%   56.52%   -0.03%     
===========================================
  Files         2484     2484              
  Lines        54742    54677      -65     
  Branches     11302    11285      -17     
===========================================
- Hits         30958    30905      -53     
+ Misses       21133    21123      -10     
+ Partials      2651     2649       -2     
Flag Coverage Δ
unit 72.16% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal changed the title chore: Disable some message menu items for encrypted messages. feat: Disable some message menu items for encrypted messages. Jun 5, 2024
@yash-rajpal yash-rajpal marked this pull request as ready for review June 10, 2024 14:57
@yash-rajpal yash-rajpal requested a review from a team as a code owner June 10, 2024 14:57
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing tests 🫣

You can create just one test to check disabled items

.changeset/plenty-buses-kneel.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have the tooltip instead of the title of the action, and a tooltip in the disabled buttons too :D

packages/i18n/src/locales/en.i18n.json Outdated Show resolved Hide resolved
hugocostadev
hugocostadev previously approved these changes Jun 17, 2024
@hugocostadev hugocostadev added this to the 6.10 milestone Jun 17, 2024
hugocostadev
hugocostadev previously approved these changes Jun 19, 2024
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2024
@yash-rajpal yash-rajpal added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@kodiakhq kodiakhq bot merged commit 45dc3d5 into develop Jun 19, 2024
35 of 48 checks passed
@kodiakhq kodiakhq bot deleted the e2e-disable-messageActions branch June 19, 2024 22:30
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants