-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disable some message menu items for encrypted messages. #32559
Conversation
🦋 Changeset detectedLatest commit: 165e52c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32559 +/- ##
===========================================
- Coverage 56.55% 56.52% -0.03%
===========================================
Files 2484 2484
Lines 54742 54677 -65
Branches 11302 11285 -17
===========================================
- Hits 30958 30905 -53
+ Misses 21133 21123 -10
+ Partials 2651 2649 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests 🫣
You can create just one test to check disabled items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to have the tooltip instead of the title of the action, and a tooltip in the disabled buttons too :D
Proposed changes (including videos or screenshots)
Currently, it is not possible to properly share the content of encrypted messages outside the room.The forwarded message, message link, or quote appears in the destination room as a hash.
So, it is needed to make clear to users that it is not possible to share encrypted messages content.
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-25