Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Disable animation on image gallery pagination transition #32581

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented Jun 10, 2024

Proposed changes (including videos or screenshots)

  • Avoid animation on image gallery pagination transition (so that there's no "glitch" when loading new images)

Issue(s)

Introduced by #32106

Steps to test or reproduce

Before:

before-transition.webm

After:

after-transition.webm

Further comments

CORE-492

@matheusbsilva137 matheusbsilva137 added this to the 6.10 milestone Jun 10, 2024
Copy link
Contributor

dionisio-bot bot commented Jun 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: 4d92a59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 changed the title regression: Use default speed in image gallery pagination transition regression: Disable animation on image gallery pagination transition Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.89%. Comparing base (811f316) to head (4d92a59).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32581      +/-   ##
===========================================
- Coverage    56.33%   55.89%   -0.44%     
===========================================
  Files         2438     2387      -51     
  Lines        53846    52899     -947     
  Branches     11103    10864     -239     
===========================================
- Hits         30334    29570     -764     
+ Misses       20861    20720     -141     
+ Partials      2651     2609      -42     
Flag Coverage Δ
e2e 55.22% <0.00%> (-0.85%) ⬇️
unit 71.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review June 10, 2024 19:28
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner June 10, 2024 19:28
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Jun 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 11, 2024
@kodiakhq kodiakhq bot merged commit 209ea9f into develop Jun 11, 2024
45 of 47 checks passed
@kodiakhq kodiakhq bot deleted the regression/image-gallery-animation-speed branch June 11, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants