-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Change Quote Position #32605
feat: Change Quote Position #32605
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8468f30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32605 +/- ##
===========================================
+ Coverage 56.43% 56.49% +0.06%
===========================================
Files 2455 2455
Lines 54098 54106 +8
Branches 11149 11155 +6
===========================================
+ Hits 30529 30569 +40
+ Misses 20909 20883 -26
+ Partials 2660 2654 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ocket.Chat into feat/quote-position
apps/meteor/client/components/message/variants/room/RoomMessageContent.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/message/variants/room/RoomMessageContent.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/message/variants/thread/ThreadMessageContent.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/message/variants/thread/ThreadMessageContent.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/helpers/ContextMessage.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/helpers/ContextMessage.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/omnichannel/contactHistory/MessageList/ContactHistoryMessage.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
Moves the quotes to be on top of the message for better readability
Issue(s)
Closes RocketChat/feature-requests#688
Closes RocketChat/feature-requests#721
Steps to test or reproduce
Further comments
CORE-501