-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Client sends incorrect file name when uploading assets #32636
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 4af2c19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32636 +/- ##
===========================================
+ Coverage 55.06% 55.85% +0.78%
===========================================
Files 2397 2421 +24
Lines 53207 53589 +382
Branches 10946 11022 +76
===========================================
+ Hits 29301 29932 +631
+ Misses 21318 21030 -288
- Partials 2588 2627 +39
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
settings-assets.spec.ts:19:6 › settings-assets › expect upload and delete logo asset and label should be visible
;Since the client used to incorrectly send the asset type as the filename, we couldn't succesfully extract the MIME type from the uploaded file. That is, when uploading a
jpeg
file as alogo
asset, the client would uselogo
as the filename, which is mapped to the defaultapplication/octet-stream
MIME type (that is not accepted for assets, so it throws an error).Issue(s)
CORE-515
Steps to test or reproduce
Further comments
This error started happening after the changes in #32471