Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Notifier accessor proxy and not rethrowing internal JSON-RPC errors #32680

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Jun 26, 2024

Proposed changes (including videos or screenshots)

Updating the Apps-Engine with fixes for the following regressions:

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 609994c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert added this to the 6.10 milestone Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.72%. Comparing base (3bffa75) to head (609994c).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32680      +/-   ##
==================================================
- Coverage           56.72%   56.72%   -0.01%     
==================================================
  Files                2496     2498       +2     
  Lines               55360    55392      +32     
  Branches            11455    11457       +2     
==================================================
+ Hits                31405    31419      +14     
+ Misses              21284    21273      -11     
- Partials             2671     2700      +29     
Flag Coverage Δ
e2e 56.46% <ø> (-0.02%) ⬇️
e2e-api 41.35% <ø> (-0.01%) ⬇️
unit 71.92% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert marked this pull request as ready for review June 27, 2024 13:36
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Jun 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 27, 2024
@d-gubert d-gubert changed the base branch from develop to release-6.10.0 June 27, 2024 23:11
@d-gubert d-gubert requested review from a team as code owners June 27, 2024 23:11
@d-gubert d-gubert force-pushed the regression/apps-deno-batch branch from 6a96c9c to b7060a2 Compare June 27, 2024 23:14
@d-gubert d-gubert force-pushed the regression/apps-deno-batch branch from b7060a2 to 609994c Compare June 28, 2024 02:20
@d-gubert d-gubert removed request for a team June 28, 2024 02:21
@ggazzo ggazzo merged commit c6add10 into release-6.10.0 Jun 28, 2024
47 of 48 checks passed
@ggazzo ggazzo deleted the regression/apps-deno-batch branch June 28, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants