-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Room breaking if advanced cron timer is invalid #32687
Conversation
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.10.0 #32687 +/- ##
==================================================
+ Coverage 56.51% 56.58% +0.07%
==================================================
Files 2495 2501 +6
Lines 55448 55528 +80
Branches 11443 11467 +24
==================================================
+ Hits 31336 31423 +87
+ Misses 21457 21415 -42
- Partials 2655 2690 +35
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add tests to ensure the behavior? I think the case that was described in the steps to reproduce would be enough, WDYT?
88e4fbe
to
3990ceb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
The base branch was changed.
This PR currently has a merge conflict. Please resolve this and then re-add the |
47db321
to
ac66477
Compare
Proposed changes (including videos or screenshots)
If the Advanced cron timer is invalid, the cron will not run, so the message was removed for this case.
Issue(s)
CORE-534
Steps to test or reproduce
Further comments