Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Room breaking if advanced cron timer is invalid #32687

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 27, 2024

Proposed changes (including videos or screenshots)

If the Advanced cron timer is invalid, the cron will not run, so the message was removed for this case.

Issue(s)

CORE-534

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team as a code owner June 27, 2024 14:18
Copy link

changeset-bot bot commented Jun 27, 2024

⚠️ No Changeset found

Latest commit: ac66477

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jun 27, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@gabriellsh gabriellsh added this to the 6.10 milestone Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (957cc80) to head (ac66477).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32687      +/-   ##
==================================================
+ Coverage           56.51%   56.58%   +0.07%     
==================================================
  Files                2495     2501       +6     
  Lines               55448    55528      +80     
  Branches            11443    11467      +24     
==================================================
+ Hits                31336    31423      +87     
+ Misses              21457    21415      -42     
- Partials             2655     2690      +35     
Flag Coverage Δ
e2e 56.46% <80.00%> (+0.07%) ⬆️
unit 71.57% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests to ensure the behavior? I think the case that was described in the steps to reproduce would be enough, WDYT?

@gabriellsh gabriellsh force-pushed the retention/boundary branch from 88e4fbe to 3990ceb Compare July 2, 2024 13:12
dougfabris
dougfabris previously approved these changes Jul 3, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Jul 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes Jul 3, 2024
@gabriellsh gabriellsh changed the base branch from develop to release-6.10.0 July 3, 2024 15:01
@gabriellsh gabriellsh dismissed stale reviews from MarcosSpessatto and dougfabris July 3, 2024 15:01

The base branch was changed.

@gabriellsh gabriellsh requested review from a team as code owners July 3, 2024 15:01
Copy link
Contributor

kodiakhq bot commented Jul 3, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2024
@d-gubert d-gubert added the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2024
@kodiakhq kodiakhq bot merged commit 0f7e52b into release-6.10.0 Jul 3, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the retention/boundary branch July 3, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants