Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression(E2EEncryption): Fix PDF preview & download not working on electron/desktop app #32698

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

rodrigok
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@rodrigok rodrigok added this to the 6.10 milestone Jun 28, 2024
Copy link
Contributor

dionisio-bot bot commented Jun 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 28, 2024

⚠️ No Changeset found

Latest commit: ad9de51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 28.00000% with 18 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-6.10.0@c6add10). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-6.10.0   #32698   +/-   ##
=================================================
  Coverage                  ?   56.69%           
=================================================
  Files                     ?     2497           
  Lines                     ?    55391           
  Branches                  ?    11461           
=================================================
  Hits                      ?    31403           
  Misses                    ?    21281           
  Partials                  ?     2707           
Flag Coverage Δ
e2e 56.41% <28.00%> (?)
unit 71.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok changed the title regression(E2EEncryption): Fix PDF preview not working on electron/desktop app regression(E2EEncryption): Fix PDF preview & download not working on electron/desktop app Jun 28, 2024
@rodrigok rodrigok marked this pull request as ready for review June 28, 2024 21:15
@rodrigok rodrigok requested a review from a team as a code owner June 28, 2024 21:15
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jul 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 1, 2024
@kodiakhq kodiakhq bot merged commit 86bf75c into release-6.10.0 Jul 2, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the regression/pdf-desktop-preview branch July 2, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants