-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: settings disappear on UI navigation back and forth #32713
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 14e96c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
96bb00f
to
20c5ef7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32713 +/- ##
===========================================
- Coverage 55.54% 54.43% -1.12%
===========================================
Files 2634 2554 -80
Lines 57215 56026 -1189
Branches 11849 11622 -227
===========================================
- Hits 31781 30495 -1286
- Misses 22742 22924 +182
+ Partials 2692 2607 -85
Flags with carried forward coverage won't be shown. Click here to find out more. |
ae796b2
to
488d5cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a changeset?
084b5f2
to
7013616
Compare
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
7013616
to
1f5fb95
Compare
Proposed changes (including videos or screenshots)
This PR addresses an issue where the "Hide System Messages" setting disappears after navigating back and forth in the Rocket.Chat UI. The problem was observed under network latency conditions when the realtime update of the setting is received much before the resolution of the saveSettings method call.
The upsert function under the
PrivateSettingsCachedCollection
replaced the original doc with the received fields, instead of merging with the original doc. This made the setting doc lose its shape and hence failed theisSetting
test in the UI components.
Before
before-hide-system-messages.mp4
After
after-hide-system-messages.mp4
Issue(s)
Steps to test or reproduce
https://your-rocketchat-domain/admin/settings/Message
.Network
tab. SelectSlow 3G
from the throttling options.Hide System Messages
setting. Click on the input field and enterUser joined
, then pressEnter
.Save changes
button.Back
button before the "Settings saved" popup appears or wait for the "Settings saved" popup to appear, then navigate back.Message
again to navigate back to the message settings page.Hide System Messages
option appears on the screen.Further comments
SUP-571