Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Not able to check file consistency when encrypted #32714

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Jul 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 2, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 2, 2024

⚠️ No Changeset found

Latest commit: e219e50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 6.10 milestone Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.58%. Comparing base (3cddda6) to head (e219e50).
Report is 6 commits behind head on release-6.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32714      +/-   ##
==================================================
+ Coverage           56.51%   56.58%   +0.06%     
==================================================
  Files                2495     2498       +3     
  Lines               55448    55484      +36     
  Branches            11443    11450       +7     
==================================================
+ Hits                31336    31394      +58     
+ Misses              21427    21403      -24     
- Partials             2685     2687       +2     
Flag Coverage Δ
e2e 56.47% <100.00%> (+0.08%) ⬆️
unit 71.55% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rodrigok rodrigok marked this pull request as ready for review July 2, 2024 23:53
@rodrigok rodrigok requested review from a team as code owners July 2, 2024 23:53
@rodrigok rodrigok added the stat: QA assured Means it has been tested and approved by a company insider label Jul 4, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 4, 2024
@rodrigok rodrigok merged commit 0eb686f into release-6.10.0 Jul 4, 2024
50 checks passed
@rodrigok rodrigok deleted the regression/fix-e2ee-missing-file-hash branch July 4, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants