Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sendFCM function not using @rocket.chat/server-fetch #32739

Merged
merged 8 commits into from
Jul 9, 2024

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jul 8, 2024

Use legacy notification provider setting is disabled in Workspace > Settings > Push, push notifications stop going to Android devices. PR Should fix this situation for using a proxy for it

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-616

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.11.0, but it targets 6.10.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 2304a31

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@debdutdeb debdutdeb changed the base branch from develop to release-6.6.10 July 8, 2024 09:26
@debdutdeb debdutdeb changed the base branch from release-6.6.10 to release-6.10.0 July 8, 2024 09:26
@debdutdeb debdutdeb added this to the 6.10 milestone Jul 8, 2024
@debdutdeb debdutdeb changed the title fix: sendFCM function not using @rocket.chat/serverFetch fix: sendFCM function not using @rocket.chat/server-fetch Jul 8, 2024
@debdutdeb debdutdeb requested review from rodrigok and Gustrb and removed request for rodrigok July 8, 2024 09:30
Gustrb
Gustrb previously approved these changes Jul 8, 2024
@debdutdeb debdutdeb marked this pull request as ready for review July 8, 2024 13:40
@debdutdeb debdutdeb modified the milestones: 6.10, 6.11 Jul 8, 2024
@debdutdeb debdutdeb changed the base branch from release-6.10.0 to develop July 8, 2024 13:44
@debdutdeb debdutdeb dismissed Gustrb’s stale review July 8, 2024 13:44

The base branch was changed.

@debdutdeb debdutdeb requested review from a team as code owners July 8, 2024 13:44
@debdutdeb debdutdeb removed request for a team July 8, 2024 13:51
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.84%. Comparing base (6d689bd) to head (2304a31).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32739      +/-   ##
===========================================
+ Coverage    50.82%   56.84%   +6.02%     
===========================================
  Files         1933     2498     +565     
  Lines        46542    55346    +8804     
  Branches      9419    11416    +1997     
===========================================
+ Hits         23654    31461    +7807     
- Misses       20755    21171     +416     
- Partials      2133     2714     +581     
Flag Coverage Δ
e2e 56.48% <ø> (+13.52%) ⬆️
unit 72.50% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman
KevLehman previously approved these changes Jul 8, 2024
@casalsgh casalsgh requested review from a team and removed request for rodrigok and a team July 8, 2024 16:32
@Gustrb Gustrb added the stat: QA assured Means it has been tested and approved by a company insider label Jul 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 8, 2024
@kodiakhq kodiakhq bot merged commit 2224150 into develop Jul 9, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the fix-fcm-proxy branch July 9, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants