Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accounts setting to reorganize sections #32744

Merged
merged 5 commits into from
Jul 15, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 8, 2024

Proposed changes (including videos or screenshots)

SIDE-81

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: bb53c6d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.47%. Comparing base (16a9c86) to head (bb53c6d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32744      +/-   ##
===========================================
- Coverage    55.53%   55.47%   -0.07%     
===========================================
  Files         2632     2632              
  Lines        57166    57172       +6     
  Branches     11839    11841       +2     
===========================================
- Hits         31749    31715      -34     
- Misses       22728    22769      +41     
+ Partials      2689     2688       -1     
Flag Coverage Δ
e2e 54.21% <75.00%> (-0.12%) ⬇️
unit 72.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the feat/sidebar-sections branch from ffebd01 to 8095262 Compare July 15, 2024 12:24
@ggazzo ggazzo added this to the 6.11 milestone Jul 15, 2024
@ggazzo ggazzo marked this pull request as ready for review July 15, 2024 12:27
@ggazzo ggazzo requested review from a team as code owners July 15, 2024 12:27
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 15, 2024
@kodiakhq kodiakhq bot merged commit 3b4b19c into develop Jul 15, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/sidebar-sections branch July 15, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants