Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README as suggested by Community Liason #32746

Merged
merged 10 commits into from
Jul 23, 2024
Merged

Conversation

casalsgh
Copy link
Contributor

@casalsgh casalsgh commented Jul 8, 2024

Proposed changes (including videos or screenshots)

Adding windows details + link to developer docs on "Local development" section.

Issue(s)

Steps to test or reproduce

Further comments

Adding windows details + link to developer docs on "Local development" section.
Copy link
Contributor

dionisio-bot bot commented Jul 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 8, 2024

⚠️ No Changeset found

Latest commit: 43de5ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@casalsgh casalsgh requested a review from tassoevan July 8, 2024 17:53
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.58%. Comparing base (3df759b) to head (43de5ad).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32746      +/-   ##
===========================================
- Coverage    55.63%   55.58%   -0.05%     
===========================================
  Files         2634     2637       +3     
  Lines        57273    57313      +40     
  Branches     11860    11869       +9     
===========================================
- Hits         31861    31860       -1     
- Misses       22723    22758      +35     
- Partials      2689     2695       +6     
Flag Coverage Δ
e2e 54.30% <ø> (-0.08%) ⬇️
unit 72.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 9, 2024
@debdutdeb debdutdeb added the stat: ready to merge PR tested and approved waiting for merge label Jul 9, 2024
@debdutdeb debdutdeb changed the title chore: update README as suggested by Community Liason docs: update README as suggested by Community Liason Jul 9, 2024
@ggazzo ggazzo removed the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@ggazzo
Copy link
Member

ggazzo commented Jul 19, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

👀

@tassoevan tassoevan added this to the 6.11 milestone Jul 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 23, 2024
@kodiakhq kodiakhq bot merged commit ee60ea6 into develop Jul 23, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the casalsgh-patch-1 branch July 23, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants