Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AAC audio type not playing on web #32763

Merged
merged 5 commits into from
Jul 15, 2024
Merged

Conversation

rodrigok
Copy link
Member

@rodrigok rodrigok commented Jul 11, 2024

Proposed changes (including videos or screenshots)

Issue(s)

NATIVE-592

Fix regression from #32471

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 11, 2024

⚠️ No Changeset found

Latest commit: 835a1b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rodrigok rodrigok added this to the 6.11 milestone Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (3b4b19c) to head (835a1b8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32763      +/-   ##
===========================================
+ Coverage    55.49%   55.57%   +0.07%     
===========================================
  Files         2632     2631       -1     
  Lines        57172    57144      -28     
  Branches     11841    11836       -5     
===========================================
+ Hits         31730    31755      +25     
+ Misses       22750    22707      -43     
+ Partials      2692     2682      -10     
Flag Coverage Δ
e2e 54.38% <100.00%> (+0.12%) ⬆️
unit 72.05% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

diegolmello
diegolmello previously approved these changes Jul 11, 2024
@rodrigok rodrigok force-pushed the fix/aac-audio-not-playing branch from 4056c3f to 1d25dbe Compare July 11, 2024 21:41
@rodrigok rodrigok force-pushed the fix/aac-audio-not-playing branch from 1d25dbe to 649999a Compare July 11, 2024 22:26
@rodrigok rodrigok marked this pull request as ready for review July 12, 2024 11:58
@rodrigok rodrigok requested a review from a team as a code owner July 12, 2024 11:58
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 15, 2024
@kodiakhq kodiakhq bot merged commit 48ea8fc into develop Jul 15, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/aac-audio-not-playing branch July 15, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants