Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: dispatchInquiryPosition being called multiple times #32767

Merged
merged 3 commits into from
Jul 11, 2024
Merged

refactor: dispatchInquiryPosition being called multiple times #32767

merged 3 commits into from
Jul 11, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 11, 2024 •
edited by jira bot
Loading

OPI-21

after checking many many many times I could not found a reason why to do this emit, if the inq is ready its going to be take and the emit will happen by other means

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 11, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d089baf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.70%. Comparing base (0adc63d) to head (d089baf).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32767      +/-   ##
===========================================
+ Coverage    56.69%   56.70%   +0.01%     
===========================================
  Files         2504     2504              
  Lines        55524    55524              
  Branches     11442    11442              
===========================================
+ Hits         31481    31487       +6     
+ Misses       21358    21354       -4     
+ Partials      2685     2683       -2
Flag Coverage Δ
e2e 56.55% <ø> (+0.01%) ⬆️
unit 72.23% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

ricardogarim
ricardogarim previously approved these changes Jul 11, 2024
View reviewed changes
@ggazzo ggazzo marked this pull request as ready for review July 11, 2024 17:47
@ggazzo ggazzo requested a review from a team as a code owner July 11, 2024 17:47
@ggazzo ggazzo added this to the 6.11 milestone Jul 11, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 11, 2024
KevLehman
KevLehman requested changes Jul 11, 2024
View reviewed changes
apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved
apps/meteor/app/livechat/server/lib/QueueManager.ts Outdated Show resolved Hide resolved
@ggazzo ggazzo added stat: needs testing and removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Jul 11, 2024
@ggazzo ggazzo merged commit 4aa6d58 into develop Jul 11, 2024
53 checks passed
@ggazzo ggazzo deleted the chore/remove-dispatch-emit-inquiry branch July 11, 2024 20:20
gabriellsh added a commit that referenced this pull request Jul 12, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into apps…
08e175a 
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
@jessicaschelly jessicaschelly added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs testing labels Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman requested changes

@ricardogarim ricardogarim ricardogarim approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Milestone
6.11
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @ricardogarim @KevLehman @jessicaschelly