-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Omnichannel): Attachments in Email Transcripts #32777
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 620a3b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32777 +/- ##
===========================================
+ Coverage 55.51% 55.57% +0.05%
===========================================
Files 2634 2634
Lines 57248 57248
Branches 11853 11853
===========================================
+ Hits 31784 31813 +29
+ Misses 22769 22744 -25
+ Partials 2695 2691 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way of adding some tests here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of PR is confusing, can you add a similar message from the changeset and show in the images who is before/after?
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Discussed on DM, will implement tests for whole class separately
Proposed changes (including videos or screenshots)
File attachments were not being handled in email transcripts, so implemented file attachments in email transcripts and invalid attachment message for attachments other than images.
Issue(s)
Steps to test or reproduce
Further comments
CORE-554