-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: e2ee "copy link" action enabled in starred and pinned message list #32803
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: abf5ca7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32803 +/- ##
===========================================
- Coverage 55.48% 55.47% -0.01%
===========================================
Files 2636 2636
Lines 57365 57367 +2
Branches 11881 11881
===========================================
- Hits 31831 31827 -4
- Misses 22837 22846 +9
+ Partials 2697 2694 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix lint issues.
Proposed changes (including videos or screenshots)
Currently, it’s possible to click on the “Copy link” inside the Starred Messages and Pinned Messages list.
The Copy link button should be disabled for E2EE channels.
Problem:
Now:
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-52