Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2ee "copy link" action enabled in starred and pinned message list #32803

Merged
merged 12 commits into from
Jul 24, 2024

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

Currently, it’s possible to click on the “Copy link” inside the Starred Messages and Pinned Messages list.

The Copy link button should be disabled for E2EE channels.

Problem:
image

Now:
image

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-52

@hugocostadev hugocostadev requested a review from a team as a code owner July 16, 2024 20:01
Copy link
Contributor

dionisio-bot bot commented Jul 16, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 16, 2024

🦋 Changeset detected

Latest commit: abf5ca7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hugocostadev hugocostadev added this to the 6.11 milestone Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.47%. Comparing base (03c8b06) to head (abf5ca7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32803      +/-   ##
===========================================
- Coverage    55.48%   55.47%   -0.01%     
===========================================
  Files         2636     2636              
  Lines        57365    57367       +2     
  Branches     11881    11881              
===========================================
- Hits         31831    31827       -4     
- Misses       22837    22846       +9     
+ Partials      2697     2694       -3     
Flag Coverage Δ
e2e 54.06% <100.00%> (-0.02%) ⬇️
unit 72.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix lint issues.

@hugocostadev hugocostadev changed the title regression: e2ee "copy link" action enabled in starred and pinned message list fix: e2ee "copy link" action enabled in starred and pinned message list Jul 17, 2024
@hugocostadev hugocostadev requested a review from yash-rajpal July 17, 2024 13:23
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 19, 2024
@kodiakhq kodiakhq bot merged commit f5ea2ff into develop Jul 24, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/e2ee_copy_link_Starred_and_Pinned branch July 24, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants