Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: pr 32541 #32814

Merged
merged 1 commit into from
Jul 19, 2024
Merged

revert: pr 32541 #32814

merged 1 commit into from
Jul 19, 2024

Conversation

debdutdeb
Copy link
Member

@debdutdeb debdutdeb commented Jul 17, 2024

This reverts commit 06707d8.

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-545

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 17, 2024

⚠️ No Changeset found

Latest commit: a3711fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.52%. Comparing base (3ffe4a2) to head (a3711fb).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32814      +/-   ##
===========================================
- Coverage    55.57%   55.52%   -0.06%     
===========================================
  Files         2634     2634              
  Lines        57216    57213       -3     
  Branches     11850    11850              
===========================================
- Hits         31800    31768      -32     
- Misses       22726    22757      +31     
+ Partials      2690     2688       -2     
Flag Coverage Δ
e2e 54.26% <ø> (-0.11%) ⬇️
unit 72.14% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb marked this pull request as ready for review July 17, 2024 18:43
@debdutdeb debdutdeb requested review from ggazzo and KevLehman July 17, 2024 18:43
@casalsgh casalsgh requested a review from MarcosSpessatto July 19, 2024 12:28
@casalsgh casalsgh added this to the 6.11 milestone Jul 19, 2024
@ggazzo ggazzo merged commit 47819cd into develop Jul 19, 2024
51 checks passed
@ggazzo ggazzo deleted the revert-06707d8 branch July 19, 2024 16:12
debdutdeb added a commit that referenced this pull request Jul 31, 2024
This reverts commit 06707d8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants