Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: close pages after page spec #32830

Merged
merged 1 commit into from
Jul 18, 2024
Merged

test: close pages after page spec #32830

merged 1 commit into from
Jul 18, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 18, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 51d2b44

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@ggazzo ggazzo requested a review from MartinSchoeler July 18, 2024 13:46
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.55%. Comparing base (b8e5887) to head (51d2b44).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32830      +/-   ##
===========================================
+ Coverage    55.54%   55.55%   +0.01%     
===========================================
  Files         2634     2634              
  Lines        57215    57215              
  Branches     11849    11849              
===========================================
+ Hits         31780    31786       +6     
+ Misses       22748    22742       -6     
  Partials      2687     2687              
Flag Coverage Δ
e2e 54.29% <ø> (+<0.01%) ⬆️
unit 72.18% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review July 18, 2024 13:55
@ggazzo ggazzo requested a review from a team as a code owner July 18, 2024 13:56
@ggazzo ggazzo added this to the 6.11 milestone Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@kodiakhq kodiakhq bot merged commit c3e9c61 into develop Jul 18, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the test/close-pages branch July 18, 2024 17:28
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants