Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect cache set review #32848

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 19, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 8685c9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 19, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ggazzo ggazzo force-pushed the fix/fix-incorrect-cache-set-review branch from b34c6d8 to 8685c9b Compare July 19, 2024 20:28
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 55.55%. Comparing base (47819cd) to head (8685c9b).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32848      +/-   ##
===========================================
+ Coverage    55.54%   55.55%   +0.01%     
===========================================
  Files         2634     2634              
  Lines        57248    57274      +26     
  Branches     11853    11866      +13     
===========================================
+ Hits         31797    31818      +21     
- Misses       22757    22791      +34     
+ Partials      2694     2665      -29     
Flag Coverage Δ
unit 72.31% <70.58%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the base branch from develop to fix-incorrect-cache-set July 19, 2024 20:49
@ggazzo ggazzo marked this pull request as ready for review July 19, 2024 20:49
@ggazzo ggazzo requested a review from a team as a code owner July 19, 2024 20:49
@debdutdeb debdutdeb merged commit 8931608 into fix-incorrect-cache-set Jul 19, 2024
39 of 41 checks passed
@debdutdeb debdutdeb deleted the fix/fix-incorrect-cache-set-review branch July 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants