-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Disabled E2EE room instances creation #32857
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 8be7a6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32857 +/- ##
===========================================
+ Coverage 55.48% 55.50% +0.02%
===========================================
Files 2637 2636 -1
Lines 57393 57362 -31
Branches 11892 11886 -6
===========================================
- Hits 31844 31839 -5
+ Misses 22850 22828 -22
+ Partials 2699 2695 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
The e2ee room instances were being created for rooms where E2EE was disabled due to a bad condition. This PR fixes this condition and now it doesn't create e2ee room instances for disabled rooms or rooms which don't have e2eKeyId.
Issue(s)
Steps to test or reproduce
Further comments
E2EE2-58