Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: create orm for specific cases #32948

Merged
merged 12 commits into from
Aug 2, 2024
Merged

chore: create orm for specific cases #32948

merged 12 commits into from
Aug 2, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 31, 2024 •
edited by jira bot
Loading

OPI-20
https://adr.rocket.chat/0099

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 31, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e4df82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 68.51852% with 17 lines in your changes missing coverage. Please review.

Project coverage is 54.98%. Comparing base (8fb9ef0) to head (cb9ee54).
Report is 19 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32948      +/-   ##
===========================================
+ Coverage    54.96%   54.98%   +0.01%     
===========================================
  Files         2595     2596       +1     
  Lines        55993    56046      +53     
  Branches     11593    11613      +20     
===========================================
+ Hits         30779    30815      +36     
- Misses       22569    22584      +15     
- Partials      2645     2647       +2
Flag Coverage Δ
unit 72.96% <68.51%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review August 2, 2024 20:34
@ggazzo ggazzo requested a review from a team as a code owner August 2, 2024 20:34
sampaiodiego
sampaiodiego requested changes Aug 2, 2024
View reviewed changes
packages/models/src/updater.ts Outdated Show resolved Hide resolved
packages/models/src/updater.ts Outdated Show resolved Hide resolved
@ricardogarim ricardogarim mentioned this pull request Aug 2, 2024
Merged
ggazzo and others added 2 commits August 2, 2024 17:15
@ggazzo @sampaiodiego
Update packages/models/src/updater.ts
3794cf3 
Co-authored-by: Diego Sampaio <chinello@gmail.com>
@ggazzo
review
2e4df82
@ggazzo ggazzo added this to the 6.12 milestone Aug 2, 2024
@ggazzo ggazzo requested a review from sampaiodiego August 2, 2024 22:20
sampaiodiego
sampaiodiego approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nojo

@ggazzo ggazzo merged commit 46a502c into develop Aug 2, 2024
11 checks passed
@ggazzo ggazzo deleted the chore/orm branch August 2, 2024 22:23
@ricardogarim ricardogarim mentioned this pull request Aug 5, 2024
Merged
gabriellsh added a commit that referenced this pull request Aug 5, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into impr…
e44bb29 
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (22 commits)
  chore: saveAnalyticsData with accumulator (#32961)
  regression: fix dispatchInquiryPosition not being fired on room creation (#32972)
  chore: create `orm` for specific cases (#32948)
  chore: create `afterOmnichannelSaveMessage` (#32970)
  fix: `Menu` onPointerUp event behavior (#32968)
  Release 6.11.0-rc.2
  feat: add `Advanced settings` on create Team and Channel (#32867)
  Revert "fix: Login services button colors" (#32955)
  chore: Use index on `unlockAll` query called when changing OM routing methods (#32860)
  chore: Exclude Storybook stories from the build of `@rocket.chat/ui-composer` (#32944)
  chore: Remove `ui-kit` from `yarn fuselage` script (#32942)
  Release 6.10.2
  fix: Client crashing on firefox private window (#32950)
  fix: Apps-Engine patch (#32935)
  test: Remove mockDate and fix unit tests (#32947) (#32949)
  fix: validate `bhType` before registering it (#32931)
  test: Remove mockDate and fix unit tests (#32947)
  Bump 6.10.2
  Release 6.11.0-rc.1
  regression: notify user properly on logout (#32920)
  ...
@ricardogarim ricardogarim mentioned this pull request Aug 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
stat: needs testing
Projects
None yet
Milestone
6.12
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @sampaiodiego @ricardogarim