Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move afterOmnichannelSaveMessage hook to work with updater #32978

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Aug 5, 2024

This pull request addresses the requirements of OPI-12 by adding updater support to the afterOmnichannelSaveMessage hook - that aims to optimize performance by reducing database calls related to omnichannel rooms.

Copy link
Contributor

dionisio-bot bot commented Aug 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 5, 2024

⚠️ No Changeset found

Latest commit: adca51e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.00%. Comparing base (41b1407) to head (adca51e).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32978   +/-   ##
========================================
  Coverage    55.00%   55.00%           
========================================
  Files         2596     2596           
  Lines        56006    56006           
  Branches     11589    11589           
========================================
  Hits         30804    30804           
  Misses       22559    22559           
  Partials      2643     2643           

apps/meteor/lib/callbacks.ts Outdated Show resolved Hide resolved
@ggazzo ggazzo force-pushed the chore/afterOmnichannelSaveMessage-updater branch from aa7ca0d to 8cb5a83 Compare August 5, 2024 16:27
@ggazzo ggazzo force-pushed the chore/afterOmnichannelSaveMessage-updater branch from 8cb5a83 to adca51e Compare August 5, 2024 16:52
@ggazzo ggazzo added this to the 6.12 milestone Aug 5, 2024
@ggazzo ggazzo marked this pull request as ready for review August 5, 2024 18:12
@ggazzo ggazzo requested review from a team as code owners August 5, 2024 18:12
@ggazzo ggazzo merged commit e2a750f into develop Aug 5, 2024
47 of 48 checks passed
@ggazzo ggazzo deleted the chore/afterOmnichannelSaveMessage-updater branch August 5, 2024 18:19
gabriellsh added a commit that referenced this pull request Aug 7, 2024
…Chat into improve/threadMetrics

* 'improve/threadMetrics' of github.com:RocketChat/Rocket.Chat:
  chore: add updater on afterOmnichannelSaveMessage (save-last-visitor-message-timestamp) hook (#32977)
  chore: move afterOmnichannelSaveMessage hook to work with updater (#32978)
  feat: Upgrade `fuselage-toastbar` adding pause on hover (#32969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants