Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: VoIP freeswitch UI admin #33004

Merged
merged 18 commits into from
Sep 23, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Aug 7, 2024

Proposed changes (including videos or screenshots)

This PR adds all necessary logic for assignment and unasignment of VoIP extensions in the admin users page. Configuring this information will allow users to make and receive call in team collab.

The changes can be broken down in three parts:

Assign/Remove extension button added to the workspace user list

Screenshot 2024-08-15 at 11 10 07

Assign extension modal

Screenshot 2024-08-15 at 11 10 30

Remove extension modal

Screenshot 2024-08-15 at 11 10 47

Issue(s)

VOIP-71

Steps to test or reproduce

  • Run your workspace
  • Enable "VoIP for Team Collaboration" in the workspace settings
  • Go to /admin/users

Further comments

Backend can be found in this PR: #32435

Copy link

changeset-bot bot commented Aug 7, 2024

⚠️ No Changeset found

Latest commit: fcbf183

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@aleksandernsilva aleksandernsilva changed the title feat: VoIP freeswitch admin UI feat: VoIP freeswitch UI admin Aug 7, 2024
@aleksandernsilva aleksandernsilva changed the base branch from feat/voip-freeswitch to feat/freeswitch-backend August 20, 2024 15:42
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 230140f to 7075979 Compare August 20, 2024 15:42
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 7075979 to 8129cb2 Compare August 20, 2024 16:46
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feat/freeswitch-6-12@ae54a18). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/freeswitch-6-12   #33004   +/-   ##
=======================================================
  Coverage                        ?   76.85%           
=======================================================
  Files                           ?      380           
  Lines                           ?    19059           
  Branches                        ?     4910           
=======================================================
  Hits                            ?    14647           
  Misses                          ?     4185           
  Partials                        ?      227           
Flag Coverage Δ
unit 76.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review August 20, 2024 20:38
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner August 20, 2024 20:38
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Aug 20, 2024
@aleksandernsilva aleksandernsilva marked this pull request as draft August 20, 2024 20:41
@aleksandernsilva aleksandernsilva added this to the 6.12 milestone Aug 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva removed the stat: QA assured Means it has been tested and approved by a company insider label Aug 21, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 21, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch 2 times, most recently from c9a70d6 to 69208b5 Compare August 22, 2024 01:41
@aleksandernsilva aleksandernsilva marked this pull request as ready for review August 22, 2024 02:44
@rodrigok rodrigok modified the milestones: 6.12, 6.13 Aug 22, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch 2 times, most recently from a653119 to 63e1b8b Compare September 13, 2024 00:47
Copy link
Contributor

github-actions bot commented Sep 13, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-23 13:46 UTC

@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from 63e1b8b to 51ce33d Compare September 13, 2024 15:22
Base automatically changed from feat/freeswitch-backend to feat/freeswitch-6-12 September 16, 2024 18:16
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner September 16, 2024 18:16
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backend

@aleksandernsilva aleksandernsilva force-pushed the feat/voip-freeswitch-ui-admin branch from b704c4c to f4d5a44 Compare September 18, 2024 16:44
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Sep 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 23, 2024
@aleksandernsilva aleksandernsilva merged commit 8389ec1 into feat/freeswitch-6-12 Sep 23, 2024
52 checks passed
@aleksandernsilva aleksandernsilva deleted the feat/voip-freeswitch-ui-admin branch September 23, 2024 13:46
@aleksandernsilva aleksandernsilva modified the milestones: 6.13, 6.14 Sep 26, 2024
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants