-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search contacts endpoint #33043
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33043 +/- ##
===========================================
- Coverage 58.58% 58.57% -0.01%
===========================================
Files 2737 2737
Lines 65757 65763 +6
Branches 14825 14826 +1
===========================================
Hits 38521 38521
- Misses 24457 24463 +6
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
1c93671
to
81d6c87
Compare
|
2d07ce1
to
3627553
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion, not really required.
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one smol request: can you put the result of the explain on the PR description so we see the indexes are doing its job? 🙏🏽
Thanks man!
Proposed changes (including videos or screenshots)
Implements a new endpoint to retrieve a list of paginated contacts, allowing sorting and filtering by name, email, or phone number.
[GET]
api/v1/omnichannel/contacts.search?searchText=john
response example:
Also, three indexes were created for the Contact collection to improve performance when querying for contacts. A normal index was created for
name
field, and partial indexes foremails
andphones
fields.Explain output showing that the indexes are being used
Issue(s)
Steps to test or reproduce
Further comments
SCI-64